# A critique of ActionScript, please

**URL:** <https://forum.kirupa.com/t/a-critique-of-actionscript-please/232031>\
**Category:** Uncategorized\
**Created:** [July 10, 2007, 5:58pm UTC](https://forum.kirupa.com/t/a-critique-of-actionscript-please/232031 "2007-07-10T17:58:35Z")\
**Posts on this page:** 1\
**Page:** 1

<div class="post-metadata">

**Author:** ![FlawlessDog](https://yyz1.discourse-cdn.com/flex011/user_avatar/forum.kirupa.com/flawlessdog/32/3633_2.png) [@FlawlessDog](https://forum.kirupa.com/u/FlawlessDog)\
**Post date:** [July 10, 2007, 5:58pm UTC](https://forum.kirupa.com/t/a-critique-of-actionscript-please/232031/1 "2007-07-10T17:58:35Z")

</div>

As some may know, I’ve been learning what I can around here, about the [Kirupa xml picture gallery](http://www.kirupa.com/developer/mx2004/xml_flash_photogallery.htm).  
I started a thread in the Source/Experiments forum, [here](http://www.kirupa.com/forum/showthread.php?t=262481), and have posted all my progress there.  
I know it doesn’t look like that much, compared to other galleries around here, but esthetics I can worry about later. A lot of what I have learned is pretty new to me, and though everything seems to be working pretty well, I am still unsure of my script and could use a critique of just my ActionScript, please.  
Am I doin’ this stuff right?  
Is it cleanly written?  
Maybe you’ll see some glaring thing, which I have completely missed…  
The only bug I am sure of is in the onMotionFinished thing in the movePic function.  
It fires when it shouldn’t…at least not as expected.  
I have an idea about that, and will address that later as well.

I have rewritten most of the script in here, though I have not really fiddled with the thumbnail script, which was written by stringy, in this [thread…](http://www.kirupa.com/forum/showpost.php?p=2001002&postcount=2)or at least this was his version of it that I started with. 😉

Anyway, here’s the version I’d like you to look at.

> **[My take on the xml gallery - Page 3](https://www.kirupa.com/forum/showthread.php?262481-My-take-on-the-xml-gallery&s=2eb61e58f9285350bcc92963f42d6552&p=2168563#post2168563)**
>
> Got a web design/development question or just want to hang out with the most awesome people on the planet? Drop on in!

  
[http://www.flawlessdog.com/eggzdownload/kirupa/photogallery008/](http://www.flawlessdog.com/eggzdownload/kirupa/photogallery008/)

Thanks in advance.

btw  
Any comments on the thread itself would be hot, too.  
I have spent a lot of time in forums like this, and if you learn somethin’ you tell about it, right.