# Whats wrong with this JS?

**URL:** https://forum.kirupa.com/t/whats-wrong-with-this-js/90795
**Category:** web dev
**Created:** [May 20, 2005, 7:27pm UTC](https://forum.kirupa.com/t/whats-wrong-with-this-js/90795 "2005-05-20T19:27:00Z")
**Posts on this page:** 1
**Page:** 1

<div class="post-metadata">

### Author: ![dinkumrocks](https://avatars.discourse-cdn.com/v4/letter/d/7feea3/32.png) [@dinkumrocks](https://forum.kirupa.com/u/dinkumrocks)
#### Post date: [May 20, 2005, 7:27pm UTC](https://forum.kirupa.com/t/whats-wrong-with-this-js/90795/1 "2005-05-20T19:27:00Z")

</div>

Ok, with my complete lack of knowledge with JS, i need some help. I’m validating a form. this is the code.

```auto
 <script LANGUAGE="JavaScript1.1">
	<!--//
	
	function checknull(myObj) {
		return myObj.value == "";
}
		
	function validateForm(frm) {
		
		var errormsg = new Array();
		
		if (checknull(frm.subject.value == "")) {
			errormsg[errormsg.length] = "Please enter a Subject.";
		}
		
		if (checknull(frm.htmlver.value=="")) {
		    errormsg[errormsg.length] = "Please enter an HTML version of the letter.";
		}
		
		if (checknull(frm.textver.value=="")) {
		    errormsg[errormsg.length] = "Please enter an TEXT version of the letter.";
		}
}	
	
		if (errormsg.length > 0) {
		 alert("Sorry, we cannot continue because of the following:

" + errormsg.join("
"));
		return false;
		} else {
		  //frm.submit();
		  return true;
		}
	}
		
	//-->
</script>

```

Then on the form, i have this.

onSubmit=“return validateForm(document.email);”

I’m so stuck.

any help?  
-Naaman