Haha! I think you are referring to that I wrote here:
With that said, you should pick and choose the [styling] techniques that make the most sense for your situation. While I am biased towards React’s way of solving our UI development problems, I’ll do my best to highlight alternate or conventional methods as well. Tying that back to what we saw here, using CSS style rules with your React content is totally OK as long as you made the decision knowing the things you gain as well as lose by doing so.
There really is no “one true” approach haha:
For web sites like what we are basically dealing with in this example, the traditional CSS file with style rules is easier to maintain.
When I’m dealing with components used as part of a larger React app, then I lean towards the “React way” of styling using an object.
My preferred approach is to have a CSS file per component similar to what you see in the todolist tutorial. It provides the flexibility of CSS, specificity, the cascade, and other good things. It also keeps things isolated enough to have each component be independent-ish.
Use whatever approach makes sense for you. All of these approaches have their Pros and Cons
(Glad you like these articles! Thanks for the nice comments!!!)
Thanks so much! So many of the React tutorials out there get so complex very quickly. I feel like you have a great balance of detail which is explained very clearly and in a way you don’t need to be an expert to implement. Exactly what I needed to carry learnings across to my own React SPA project - thanks again!!
I really enjoy your articles on React. They’re extremely helpful and informative with learning React and gaining confidence with it.
I’m running into a bit of an issue with React Router, though. I’ve adapted this tutorial into a bit larger of an app to give it navigation, but it seems that if I use components with state in the routes, I run into this warning and my app stops functioning properly after navigating away from the component with state: “Can’t call setState on an unmounted component…”
I’m sure it’s something simple that I’m missing, but I’ve been fighting with this for a while now and my frustration is clouding my ability to spot details. Would you mind giving some advice on increasing the complexity of an app that uses React Router?
I have a project on Github that exhibits this behavior if you need to see it in action
Well, see here’s the thing about that. I’ve run into a few articles that mention this issue, and it makes sense, but I don’t think I’m doing this exactly. I’m not using isMounted at all, and I’m not using Flux for this project. I’m simply calling setState in a function that’s called in componentDidMount and then in a handler that’s passed to a lower-level component (which itself never calls setState), which looks legal to my inexperienced eyes.
Here’s the project I’m working on that exhibits this issue. You’ll see the BrowserRouter used in src/App.js and it’s the handleSelect(id) function in the ADD2Characters class that raises the warning.
Could it have something to do with the onClick in ADD2CharacterTable? I just noticed that while looking it over again
I think I just managed something… I just made a commit to that repo that converts the ADD2CharacterTable component to a function component, and this appears to get around the issue. Would you agree with this solution, or is it just a hack made by someone who doesn’t know any better?
After looking through your code, I am not 100% sure why you had the original problem to begin with haha. With that said, avoiding any knowledge of state by going to a functional component is one way of avoiding this issue entirely. Since your app works fine now, I wouldn’t question it too much!