[PHP/MySQL] Switch - Case, how to shorten the code

1

Hi,

Is this a bad way to code?? Probably it is…

How can I shorten the code, so that if I have to make a change, I don’t need to replace alot…?

Here the ‘$svar_antall’ can be 2-4, but if it gets bigger… I’ll have a big problem … :slight_smile:


 
/ --------------------------------------------------------------------
//Insert into database
if($_POST){ 
$svar_antall = $_POST['svar_antall'];
$ny_test_ID = $_POST['svar_test_ID'];
$ny_spm = $_POST['spm_spm_ID'];
$svar_spmID = $_POST['svar_spmID'];
 
 
switch($svar_antall){
case 1:
	$svar_1 = $_POST['svar_1'];
	break;
case 2;
	$svar_1 = $_POST['svar_1'];
	$svar_2 = $_POST['svar_2'];
	break;
case 3:
	$svar_1 = $_POST['svar_1'];
	$svar_2 = $_POST['svar_2'];
	$svar_3 = $_POST['svar_3'];
	break;
case 4:
	$svar_1 = $_POST['svar_1'];
	$svar_2 = $_POST['svar_2'];
	$svar_3 = $_POST['svar_3'];
	$svar_4 = $_POST['svar_4'];
	break;
}
 
if( (strlen($svar_1) == 0) || strlen($svar_2) == 0 ){
	die ("Noen felt mangler!");
}else {
	switch($svar_antall){
	 case 1:
	 $svar_1 = $_POST['svar_1'];
	 break;
	 case 2;
	 $query = "INSERT INTO Kyle_Svar(TestID, SvarKey, SpmID, SvarText) 
	 VALUES('$ny_test_ID', '$svar_spmID', '$ny_spm', '$svar_1')";
 
	 if ($result2 = mysql_query($query)){
	 echo "<br><div align=\"center\" class=\"tekst\"><strong>Svar 1</strong> og ";
	 }else
		skriv_mysql_feil(); 
 
	 $svar_spmID++;
 
	 $query = "INSERT INTO Kyle_Svar(TestID, SvarKey, SpmID, SvarText) 
	 VALUES('$ny_test_ID', '$svar_spmID', '$ny_spm', '$svar_2')";
 
	 if ($result2 = mysql_query($query)){
	 echo "<strong>Svar 2 lagret</strong></div><br>";
	 }else
		skriv_mysql_feil(); 
 
	 break;
	 case 3:
	 $query = "INSERT INTO Kyle_Svar(TestID, SvarKey, SpmID, SvarText) 
	 VALUES('$ny_test_ID', '$svar_spmID', '$ny_spm', '$svar_1')";
 
	 if ($result2 = mysql_query($query)){
	 echo "<br><div align=\"center\" class=\"tekst\"><strong>Svar 1<strong>, ";
	 }else
		skriv_mysql_feil(); 
 
	 $svar_spmID++;
 
	 $query = "INSERT INTO Kyle_Svar(TestID, SvarKey, SpmID, SvarText) 
	 VALUES('$ny_test_ID', '$svar_spmID', '$ny_spm', '$svar_2')";
 
	 if ($result2 = mysql_query($query)){
	 echo "<strong>Svar 2</strong> og ";
	 }else
		skriv_mysql_feil(); 
 
	 $svar_spmID++;
 
	 $query = "INSERT INTO Kyle_Svar(TestID, SvarKey, SpmID, SvarText) 
	 VALUES('$ny_test_ID', '$svar_spmID', '$ny_spm', '$svar_3')";
 
	 if ($result2 = mysql_query($query)){
	 echo "<strong>Svar 3 lagret</strong></div><br>";
	 }else
		skriv_mysql_feil(); 
	 break;
	 case 4:
	 $query = "INSERT INTO Kyle_Svar(TestID, SvarKey, SpmID, SvarText) 
	 VALUES('$ny_test_ID', '$svar_spmID', '$ny_spm', '$svar_1')";
 
	 if ($result2 = mysql_query($query)){
	 echo "<br><div align=\"center\" class=\"tekst\"><strong>Svar 1</strong>, ";
	 }else
		skriv_mysql_feil(); 
 
	 $svar_spmID++;
 
	 $query = "INSERT INTO Kyle_Svar(TestID, SvarKey, SpmID, SvarText) 
	 VALUES('$ny_test_ID', '$svar_spmID', '$ny_spm', '$svar_2')";
 
	 if ($result2 = mysql_query($query)){
	 echo "<strong>Svar 2</strong>, ";
	 }else
		skriv_mysql_feil(); 
 
	 $svar_spmID++;
 
	 $query = "INSERT INTO Kyle_Svar(TestID, SvarKey, SpmID, SvarText) 
	 VALUES('$ny_test_ID', '$svar_spmID', '$ny_spm', '$svar_3')";
 
	 if ($result2 = mysql_query($query)){
	 echo "<strong>Svar 3</strong>, ";
	 }else
		skriv_mysql_feil(); 
 
	 $svar_spmID++;
 
	 $query = "INSERT INTO Kyle_Svar(TestID, SvarKey, SpmID, SvarText) 
	 VALUES('$ny_test_ID', '$svar_spmID', '$ny_spm', '$svar_4')";
 
	 if ($result2 = mysql_query($query)){
	 echo "<strong>Svar 4 lagret</strong></div><br>";
	 }else
		skriv_mysql_feil(); 
	 break;
	}
 
 
}
 
}

Thanx