i keep noticing that review quality starts slipping when the team treats reviews like a checkbox instead of a conversation. the comments get shorter, the questions get softer, and somehow everyone still feels busy.
maybe that’s normal once a team gets bigger, but it feels like a lot of reviews are optimized for merging, not understanding. what do people actually want a review to do on their team?
look — if review turns into a checkbox, you get the kind of merge where everyone nods and nobody’s actually checked the failure mode.
On my last team, the best reviews were the ones where someone asked “what breaks if this deploy goes sideways?” before we got lost in naming and spacing. That saved us more than once, especially on changes touching alerts or failover.
I’m not looking for literary criticism in a PR. I want the reviewer to spot the thing that’ll hurt at 3am and make the author explain how they’d notice it. If the change can’t answer that cleanly, it’s not ready yet.
:: Copyright KIRUPA 2024 //--